[llvm] r321010 - [PPC] Disable reg+reg to reg+imm transformation.

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 15:03:22 PST 2017


The pass author is working on a fix already that should come with a
test case, and I was too lazy to get my test case into a usable form,
it's really brittle :(

On Mon, Dec 18, 2017 at 11:43 PM, Davide Italiano <davide at freebsd.org> wrote:
> Maybe you can add the test that's breaking here? (so that if somebody
> tries to enable this again will get a failure).
>
> On Mon, Dec 18, 2017 at 10:56 AM, Benjamin Kramer via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: d0k
>> Date: Mon Dec 18 10:56:57 2017
>> New Revision: 321010
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=321010&view=rev
>> Log:
>> [PPC] Disable reg+reg to reg+imm transformation.
>>
>> It creates invalid instructions. PR35688.
>>
>> Modified:
>>     llvm/trunk/lib/Target/PowerPC/PPCMIPeephole.cpp
>>
>> Modified: llvm/trunk/lib/Target/PowerPC/PPCMIPeephole.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCMIPeephole.cpp?rev=321010&r1=321009&r2=321010&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/PowerPC/PPCMIPeephole.cpp (original)
>> +++ llvm/trunk/lib/Target/PowerPC/PPCMIPeephole.cpp Mon Dec 18 10:56:57 2017
>> @@ -55,7 +55,7 @@ FixedPointRegToImm("ppc-reg-to-imm-fixed
>>                              "convert reg-reg instructions to reg-imm"));
>>
>>  static cl::opt<bool>
>> -ConvertRegReg("ppc-convert-rr-to-ri", cl::Hidden, cl::init(true),
>> +ConvertRegReg("ppc-convert-rr-to-ri", cl::Hidden, cl::init(false),
>>                cl::desc("Convert eligible reg+reg instructions to reg+imm"));
>>
>>  static cl::opt<bool>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare


More information about the llvm-commits mailing list