[PATCH] D40876: AArch64: Fix emergency spillslot being out of reach for large callframes
Geoff Berry via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 18 13:04:29 PST 2017
gberry added a comment.
In https://reviews.llvm.org/D40876#958683, @gberry wrote:
> One thing I noticed when looking at this: it seems fragile to me to have MachineFrameInfo::computeMaxCallFrameSize() and PEI::calculateFrameInfo() doing essentially the same calculation with duplicated code.
> Would it make sense to add an assert to PEI::calculateFrameInfo that checks that the previously calculated MaxCallFrameSize isn't smaller than the one calculated later?
After thinking about this some more, adding this assert doesn't make much sense, since e.g. spilling will increase the MaxCallFrameSize. Speaking of which, don't we still have a problem if e.g. spilling puts us over the large frame size threshold?
More information about the llvm-commits