[PATCH] D41335: [InlineFunction] Inline vararg functions that do not access varargs.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 12:36:17 PST 2017


fhahn added a comment.

In https://reviews.llvm.org/D41335#958636, @efriedma wrote:

> "musttail" calls forward varargs arguments to the callee.


Ah thanks I was not sure about that! So in the test case, we should have to forward `i32 42` to the `musttail` call, e.g. `call void (i8*, ...) bitcast (void (i8*, i32)* @ext_method to void (i8*, ...)*)(i8* %this_adj.i, i32 42)`? If that's the case, then it makes sense to keep the forwarding code in InlineFunction and I'll update https://reviews.llvm.org/D41336 accordingly.


https://reviews.llvm.org/D41335





More information about the llvm-commits mailing list