[PATCH] D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 10:58:20 PST 2017

craig.topper added inline comments.

Comment at: lib/Target/X86/X86DomainReassignment.cpp:317
-  /// The register domain of this closure.
-  RegDomain Domain;
guyblank wrote:
> IMO the domain should remain part of the closure itself. as opposed to the other removed fields, it really is a property of the closure.
I removed it because it was only used during buildClosure and wasn't needed after that. So I just made it a local variable in buildClosure and passed it by reference to visitRegister.


More information about the llvm-commits mailing list