[PATCH] D41231: [Support][CachePruning] Fix regression that prevents disabling of pruning
ben via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 18 08:22:37 PST 2017
bd1976llvm updated this revision to Diff 127367.
bd1976llvm added a comment.
Thanks for the great review comments.
I didn't realize that it was easy to write a test for this via llvm-lto (i.e. I hadn't noticed that the c/c++ legacy apis share a backend!) otherwise I would have added a test without prompting.
Absolutely correct about the danger of overflow with chrono duration types. In fact on windows we do actually get this overflow occurring. This is because on windows the modification time for files is of type nanoseconds as opposed to seconds on e.g. linux (see: getLastModificationTime). I have attempted to make the code safer at the cost of half a second of precision.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5557 bytes
Desc: not available
More information about the llvm-commits