[PATCH] D40363: [AArch64][SVE] Asm: Improve diagnostics further when +sve is not specified

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 07:24:33 PST 2017

sdesmalen added a comment.

In https://reviews.llvm.org/D40363#957096, @fhahn wrote:

> Could you check if we have similar features & test cases for Armv8.1-a instructions before committing this?

The Armv8.1-a assembler tests don't seem to include cases to run with the Armv8.1-a features disabled, so I ran some manually and got mostly expected results.
One thing however that is worth pointing out is that for e.g. the 'casp' instructions it will now give a specific error other than 'invalid operand for instruction', because when it tries to parse the operands for 'casp' the tryParseGPRSeqPair method itself emits custom error messages depending on what it expects. Because it uses direct calls to Error(), those will not be prevented by the mechanism implemented by: https://reviews.llvm.org/D40362.
I don't think this is ever much of an issue in practice, but if it will be, then it is possible to create a wrapper function around Error() that checks the feature bits.


More information about the llvm-commits mailing list