[PATCH] D40347: [JumpThreading] Restrict PRE across instructions that don't pass control to successors

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 06:09:38 PST 2017

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.


Comment at: lib/Transforms/Scalar/JumpThreading.cpp:1337
+  // If the value is unavailable in one of predecessors, we will end up
+  // inserting a new instruction into them. We can only validly do it if all
+  // instructions before LI are guaranteed to pass execution to its successor,
Nit: s/We can only validly do it if/This is valid only if/


More information about the llvm-commits mailing list