[PATCH] D41333: [ValueTracking] ignore FP signed-zero when detecting a casted-to-integer fmin/fmax pattern

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 02:38:07 PST 2017


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM thanks!



================
Comment at: test/Transforms/InstCombine/minmax-fp.ll:163
+; CHECK-NEXT:    [[TMP1:%.*]] = select i1 [[DOTINV]], float 0.000000e+00, float %a
+; CHECK-NEXT:    [[TMP2:%.*]] = fptosi float [[TMP1]] to i8
+; CHECK-NEXT:    ret i8 [[TMP2]]
----------------
Could you extend the test to also check the case when the select operands are flipped?


https://reviews.llvm.org/D41333





More information about the llvm-commits mailing list