[PATCH] D41294: [X86][SSE] Use (V)PHMINPOSUW for vXi8 SMAX/SMIN/UMAX/UMIN horizontal reductions (PR32841)

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 16 22:50:36 PST 2017


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:30494
   SDValue Mask;
+  unsigned MaskEltsBits = ExtractVT.getScalarSizeInBits();
   if (BinOp == ISD::SMAX)
----------------
Shouldn't this just be getSizeInBits()? It's already scalar.


Repository:
  rL LLVM

https://reviews.llvm.org/D41294





More information about the llvm-commits mailing list