[PATCH] D41327: [X86] Refactor DomainReassignment pass to make the Closure class not stores references to the main data structures of the pass itself

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 16 19:27:01 PST 2017


craig.topper created this revision.
craig.topper added reviewers: guyblank, RKSimon.

Multiple Closure objects can be created and stored for a single function. It's not a good idea to devote so many fields of it to storing pointers and references to global data structures of the pass. The closure class should only store the things needed to represent the closure itself.

This pass refactors many of the methods of Closure to belong to the pass object and to pass around a reference to the current Closure. The Closure class gains a few simple methods to add instructions and edges, and to return iterators to edges and instructions.


https://reviews.llvm.org/D41327

Files:
  lib/Target/X86/X86DomainReassignment.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41327.127265.patch
Type: text/x-patch
Size: 10750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171217/1458edd9/attachment.bin>


More information about the llvm-commits mailing list