[PATCH] D41279: [ThinLTO][C-API] Correct api comments

Katya Romanova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 23:36:57 PST 2017


kromanova added inline comments.


================
Comment at: include/llvm-c/lto.h:795
 /**
  * Sets the maximum cache size that can be persistent across build, in terms of
  * percentage of the available space on the the disk. Set to 100 to indicate
----------------
Please apply the same changes as you did for thinlto_codegen_set_cache_pruning_interval
to the rest of thinLTO APIs responsible for pruning policy/incremental builds.
Otherwise, the comments look inconsistent.

E.g. for thinlto_codegen_set_final_cache_size_relative_to_available_space,
the following changes has to be made:

(1) across build -> across builds
(2) An unspecified default value will be applied -> Default is 75% (see comment in CachePruning.h)


================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:152
+  /// Cache policy: interval (seconds) between two prunes of the cache. A
+  /// negative value sets the maximum possible pruning interval. A value
+  /// of 0 will be ignored.
----------------
Please mention one more time here that negative values effectively disable pruning


https://reviews.llvm.org/D41279





More information about the llvm-commits mailing list