[lld] r315658 - Slightly simplify code and add comment.

[Rafael Avila de Espindola via llvm-commits]

Ed Maste via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Hi Rui,
>
> I can confirm that lld does in fact not behave exactly the same way
> with this patch :)
>
> I was investigating lld on FreeBSD/i386, and found that with lld 5.0.1
> in FreeBSD-HEAD we encounter an assertion failure from libc at
> startup, for all dynamically linked i386 binaries. Testing with lld
> HEAD was successful. Bisection turned up r315658 - it was a bit tricky
> because r315552 introduced a regression that caused libc to fail to
> link, fixed in r315737. In any case, r315658 has the pleasant
> side-effect of fixing lld for FreeBSD/i386.
>
> I'm investigating the differences in the output .so when linked with
> lld with/without this patch and will follow up with my findings. I'd
> like to try to add a test case for the behaviour that changed so that
> we can ensure it doesn't regress, then Dimitry or I will likely merge
> it into the lld 5.0.1 in FreeBSD.

If you put the output of --reproduce somewhere it shouldn't be too hard
to reduce it.

Cheers,
Rafael