[PATCH] D41312: [testsuite] Un-XFAIL a test with global variables

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 16:39:27 PST 2017


davide created this revision.
davide added reviewers: jasonmolenda, jingham, friss, aprantl, vsk, JDevlieghere.

Turns out this was fixed in LLVM a while ago. I propose to reenable, as currently it's annoyingly reported as an unexpected success


https://reviews.llvm.org/D41312

Files:
  packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py


Index: packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
===================================================================
--- packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
+++ packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
@@ -22,12 +22,6 @@
         self.shlib_names = ["a"]

     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764")
-    @expectedFailureAll(
-        "llvm.org/pr25872, <rdar://problem/28725399>",
-        oslist=["macosx"],
-        debug_info=[
-            "dwarf",
-            "gmodules"])
     def test_c_global_variables(self):
         """Test 'frame variable --scope --no-args' which omits args and shows scopes."""
         self.build()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41312.127205.patch
Type: text/x-patch
Size: 778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171216/f2dca62a/attachment.bin>


More information about the llvm-commits mailing list