[PATCH] D41264: Fix faulty assertion for void type in debug info

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 15:36:17 PST 2017


amccarth updated this revision to Diff 127200.
amccarth added a comment.

Made part of the fix more localized, preserving one of the assertions.

Added an IR test that demonstrates the problem.

rnk succinctly described the problem in the bug report:

> Right, this bug only occurs if the user asks for *both* DWARF and CodeView. We don't really support that configuration, but we didn't take any steps to disable it because there's nothing technically challenging about allowing it.



> In this case, what's happening is we're emitting extra DI metadata (nested typedefs, in this case the one for 'void') to support CodeView, and the DWARF asm printer doesn't seem ready for it.


https://reviews.llvm.org/D41264

Files:
  llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/test/DebugInfo/void-typedef.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41264.127200.patch
Type: text/x-patch
Size: 5925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171215/f4056c0a/attachment.bin>


More information about the llvm-commits mailing list