[PATCH] D41267: [LTO] Make processing of combined module more consistent

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 13:13:43 PST 2017


pcc added a comment.

Please add a test that shows that we create an empty object file with the correct target triple.



================
Comment at: llvm/include/llvm/LTO/LTO.h:295
     std::vector<AddedModule> ModsWithSummaries;
+    std::string EmptyModuleTargetTriple;
   } RegularLTO;
----------------
vitalybuka wrote:
> pcc wrote:
> > Remove this field.
> are you askin to merge RegularLTOState and ThinLTOState?
No, I was talking about `EmptyModuleTargetTriple` which you have removed.


https://reviews.llvm.org/D41267





More information about the llvm-commits mailing list