[llvm] r320862 - [X86] Remove unnecessary TODO.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 12:57:18 PST 2017


Author: ctopper
Date: Fri Dec 15 12:57:18 2017
New Revision: 320862

URL: http://llvm.org/viewvc/llvm-project?rev=320862&view=rev
Log:
[X86] Remove unnecessary TODO.

When I wrote it I thought we were missing a potential optimization for KNL. But investigating further shows that for KNL we still do the optimal thing by widening to v4f32 and then using special isel patterns to widen again to zmm a register.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=320862&r1=320861&r2=320862&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Dec 15 12:57:18 2017
@@ -1566,7 +1566,6 @@ X86TargetLowering::X86TargetLowering(con
     setTruncStoreAction(MVT::v4i32, MVT::v4i16, Legal);
 
     if (Subtarget.hasDQI()) {
-      // TODO: these shouldn't require VLX. We can widen to 512-bit with AVX512F.
       // Fast v2f32 SINT_TO_FP( v2i64 ) custom conversion.
       // v2f32 UINT_TO_FP is already custom under SSE2.
       setOperationAction(ISD::SINT_TO_FP,    MVT::v2f32, Custom);




More information about the llvm-commits mailing list