[PATCH] D41090: [DWARFv5] Dump MD5 checksum from line-table header

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DIE.cpp:780
   case dwarf::DW_FORM_block:  Asm->EmitULEB128(Size); break;
+  case dwarf::DW_FORM_data16:
+    break;
----------------
aprantl wrote:
> for consistency with the surrounding code, perhaps all on one line?
I agree. clang-format did this, but clearly it wants one line per case.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DIE.cpp:797
+  case dwarf::DW_FORM_data16:
+    return 16;
   default: llvm_unreachable("Improper form for block");
----------------
aprantl wrote:
> same here?
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D41090