[llvm] r320850 - [X86] Remove assert in X86MCCodeEmitter.cpp that was added in r320830.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 11:38:14 PST 2017


Author: ctopper
Date: Fri Dec 15 11:38:14 2017
New Revision: 320850

URL: http://llvm.org/viewvc/llvm-project?rev=320850&view=rev
Log:
[X86] Remove assert in X86MCCodeEmitter.cpp that was added in r320830.

It seems to be failing real code which is concerning, but we were silently getting away with it. I'll investigate further.

Modified:
    llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp

Modified: llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp?rev=320850&r1=320849&r2=320850&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp (original)
+++ llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp Fri Dec 15 11:38:14 2017
@@ -1130,8 +1130,6 @@ bool X86MCCodeEmitter::emitOpcodePrefix(
       EmitByte(0x40 | REX, CurByte, OS);
       Ret = true;
     }
-  } else {
-    assert(!(TSFlags & X86II::REX_W) && "REX.W requires 64bit mode.");
   }
 
   // 0x0F escape code must be emitted just before the opcode.




More information about the llvm-commits mailing list