[lld] r315658 - Slightly simplify code and add comment.

[Ed Maste via llvm-commits]

On 12 October 2017 at 21:19, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: ruiu
> Date: Thu Oct 12 18:19:10 2017
> New Revision: 315658
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315658&view=rev
> Log:
> Slightly simplify code and add comment.
>
> This is not a mechanical transformation. Even though I believe this
> patch is correct, I'm not 100% sure if lld with this patch behaves
> exactly the same way as before on all edge cases. At least all tests
> still pass.

Hi Rui,

I can confirm that lld does in fact not behave exactly the same way
with this patch :)

I was investigating lld on FreeBSD/i386, and found that with lld 5.0.1
in FreeBSD-HEAD we encounter an assertion failure from libc at
startup, for all dynamically linked i386 binaries. Testing with lld
HEAD was successful. Bisection turned up r315658 - it was a bit tricky
because r315552 introduced a regression that caused libc to fail to
link, fixed in r315737. In any case, r315658 has the pleasant
side-effect of fixing lld for FreeBSD/i386.

I'm investigating the differences in the output .so when linked with
lld with/without this patch and will follow up with my findings. I'd
like to try to add a test case for the behaviour that changed so that
we can ensure it doesn't regress, then Dimitry or I will likely merge
it into the lld 5.0.1 in FreeBSD.