[PATCH] D41273: [cmake] Remove redundant check for Targets to build

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In https://reviews.llvm.org/D41273#956447, @asb wrote:

> I have the same concern with this as I described in the discussion around r320413 <http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20171211/509800.html>.
>
> With this change, I can directly specify an experimental backend using -DLLVM_TARGETS_TO_BUILD and it will "just work". I think there is value in requiring experimental backends to be specified separately with -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD. It means that anyone auditing the build configuration can see at a glance when an experimental backend is being built, which I think is important given the lack of stability guarantees for these backends. Did you intend that change in behaviour?


If you find it useful, I'm happy to leave it in, but we should at least change the error message to reflect what's really going on, i.e., the target was found but not explicitly passed as experimental.


https://reviews.llvm.org/D41273