[PATCH] D40942: [X86] Fix insert_vector_elt lowering for v32i1/v64i1 with non-constant index

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - Is it worth adding non-legal types for testing as well e.g. <128 x i1> or <96 x i1>?



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:14687
+    MVT ExtVecVT = MVT::getVectorVT(MVT::getIntegerVT(VecSize/NumElts), NumElts);
+    MVT ExtEltVT = ExtVecVT.getVectorElementType();
     SDValue ExtOp = DAG.getNode(ISD::INSERT_VECTOR_ELT, dl, ExtVecVT,
----------------
clang-format this (VecSize / NumElts) ?


https://reviews.llvm.org/D40942