[PATCH] D40146: [JumpThreading] Preservation of DT and LVI across the pass

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 07:38:30 PST 2017


brzycki added a comment.

In https://reviews.llvm.org/D40146#955920, @kuhar wrote:

> Which files and includes formed the cycle? There are a lot of files that require dominators.h, and I'm not convinced adding a new class to is a good idea, given that it currently has just one user.


@kuhar would it help if I put all the larger functions in Dominators.cpp to prevent aggressive inlining? That would make it a relatively small class.


https://reviews.llvm.org/D40146





More information about the llvm-commits mailing list