[PATCH] D32872: [PowerPC] Leverage PGO data to version/expand small/large memcpy calls

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCLowerMemIntrinsics.cpp:93
 
+  bool shouldExpandMemCpy(MemCpyInst *MC, ProfileSummaryInfo *PSI, BlockFrequencyInfo &BFI);
   bool runOnModule(Module &M) override;
----------------
Line too long.


================
Comment at: lib/Target/PowerPC/PPCLowerMemIntrinsics.cpp:141
+  // Do not expand cold call sites based on profiling information
+  bool hasPGOInfo = false;
+  if (PSI) {
----------------
hasPGOInfo -> HasPGOInfo


================
Comment at: lib/Target/PowerPC/PPCLowerMemIntrinsics.cpp:160
+
+// returns condition to be used to determine unknown size memCpy expansion
+static Value *getExpandUnknownSizeMemCpyCond(MemCpyInst *MI) {
----------------
Comments should be complete sentences, starting with a capital letter, and ending with a period (here and below).


https://reviews.llvm.org/D32872