[PATCH] D41269: [COFF] Warn for locally imported symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/SymbolTable.cpp:102
         LocalImportChunks.push_back(cast<DefinedLocalImport>(Sym)->getChunk());
+        UndefsToLocalImports.try_emplace(Sym, D);
         continue;
----------------
Can you just call warn() here?


================
Comment at: test/COFF/locally-imported.test:6
 
+# WARN: warning: [[INPUT:[^:]+]]: locally defined symbol imported: main (defined in [[INPUT]])
+
----------------
I wouldn't repeat the filename twice in the same line.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41269