[PATCH] D41146: [DWARF] DWARF v5: Rework of string offsets table reader

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 17:33:26 PST 2017


wolfgangp updated this revision to Diff 127049.
wolfgangp marked 7 inline comments as done.
wolfgangp added a comment.

Addressed review comments. Streamlined the parseDWARF??StringOffsetsTableHeader() functions a bit and implemented a couple of other suggested changes.


https://reviews.llvm.org/D41146

Files:
  include/llvm/DebugInfo/DWARF/DWARFUnit.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  test/DebugInfo/X86/dwarfdump-str-offsets-dwp.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-3.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-4.s
  test/DebugInfo/X86/dwarfdump-str-offsets-invalid-6.s
  test/DebugInfo/X86/dwarfdump-str-offsets-macho.s
  test/DebugInfo/X86/dwarfdump-str-offsets.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41146.127049.patch
Type: text/x-patch
Size: 53299 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171215/f34d19d6/attachment.bin>


More information about the llvm-commits mailing list