[llvm] r320784 - [X86] Add a TODO about v8i1 CONCAT_VECTORS.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 17:03:46 PST 2017


Author: ctopper
Date: Thu Dec 14 17:03:46 2017
New Revision: 320784

URL: http://llvm.org/viewvc/llvm-project?rev=320784&view=rev
Log:
[X86] Add a TODO about v8i1 CONCAT_VECTORS.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=320784&r1=320783&r2=320784&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Thu Dec 14 17:03:46 2017
@@ -1538,6 +1538,9 @@ X86TargetLowering::X86TargetLowering(con
       setOperationAction(ISD::VECTOR_SHUFFLE,     VT, Custom);
     }
 
+    // TODO: v8i1 concat should be legal without VLX to support concats of
+    // v1i1, but we won't legalize it correctly currently without introducing
+    // a v4i1 concat in the middle.
     setOperationAction(ISD::CONCAT_VECTORS,     MVT::v8i1, Custom);
     setOperationAction(ISD::CONCAT_VECTORS,     MVT::v4i1, Custom);
     setOperationAction(ISD::INSERT_SUBVECTOR,   MVT::v4i1, Custom);




More information about the llvm-commits mailing list