[PATCH] D41257: Use warn() instead of error() to report a bad symbol in a DSO.

[Rui Ueyama via llvm-commits]

On Thu, Dec 14, 2017 at 4:14 PM, Peter Collingbourne via Phabricator <
reviews at reviews.llvm.org> wrote:

> pcc added inline comments.
>
>
> ================
> Comment at: lld/trunk/test/ELF/invalid-local-symbol-in-dso.s:4
>  # We used to crash on this
> -# RUN: not ld.lld %t.o %p/Inputs/local-symbol-in-dso.so -o %t 2>&1 |
> FileCheck %s
> -# CHECK: Found local symbol 'foo' in global part of symbol table in file
> {{.*}}local-symbol-in-dso.so
> +# RUN: echo | llvm-mc - -o %t1.o -filetype=obj -triple x86_64-pc-linux
> +# RUN: ld.lld %t1.o %p/Inputs/local-symbol-in-dso.so -o %t 2>&1 | \
> ----------------
> Do you need to create an object file? Can you just pass the .so file?


Yes I can. Fixed in r320773.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171214/037d8272/attachment.html>