[PATCH] D41257: Use warn() instead of error() to report a bad symbol in a DSO.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 15:53:56 PST 2017


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/ELF/invalid-local-symbol-in-dso.s:4
 # We used to crash on this
-# RUN: not ld.lld %t.o %p/Inputs/local-symbol-in-dso.so -o %t 2>&1 | FileCheck %s
+# RUN: ld.lld %t.o %p/Inputs/local-symbol-in-dso.so -o %t 2>&1 | FileCheck %s
 # CHECK: Found local symbol 'foo' in global part of symbol table in file {{.*}}local-symbol-in-dso.so
----------------
Can we also test that we fail to link against the symbol?


https://reviews.llvm.org/D41257





More information about the llvm-commits mailing list