[PATCH] D40975: [LangRef] Reflect the changes in the TBAA info format

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 15:19:02 PST 2017


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This is good. Don't commit it, however, until it's meaningful (i.e., once the corresponding implementation lands).



================
Comment at: docs/LangRef.rst:4635
 
-As a concrete example, the type descriptor graph for the following program
+ * the base types of the accesses are the same type and the ranges of accessed
+   bytes within that type overlap, or
----------------
the base -> The base


================
Comment at: docs/LangRef.rst:4638
+
+ * the base type of one access is the type of a *direct* or *indirect* field of
+   the other base type and the ranges of accessed bytes within that field type
----------------
the base -> The base


================
Comment at: docs/LangRef.rst:4683
+
+      // Accesses to union members are not supported yet, and conservatively
+      // represented as accesses to character arrays. Note that in C and C++,
----------------
I thought that, in the new format, we were going to support unions by allowing multiple fields at the same offset. Are you planning to just do that as a follow-up set of patches?


https://reviews.llvm.org/D40975





More information about the llvm-commits mailing list