[PATCH] D40912: TLI: Expose all MMO flags in getTgtMemIntrinsic

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5779
 SDValue SelectionDAG::getMemIntrinsicNode(
-    unsigned Opcode, const SDLoc &dl, SDVTList VTList, ArrayRef<SDValue> Ops,
-    EVT MemVT, MachinePointerInfo PtrInfo, unsigned Align, bool Vol,
-    bool ReadMem, bool WriteMem, unsigned Size) {
+    unsigned Opcode, const SDLoc &SL, SDVTList VTList, ArrayRef<SDValue> Ops,
+    EVT MemVT, MachinePointerInfo PtrInfo, unsigned Align,
----------------
arsenm wrote:
> hfinkel wrote:
> > Please don't change dl to SL here. dl is our standard names for these things (because they're essentially debug locations and everyone knows that dl/DL means).
> I thought these were gradually changing to SL because it's now called SDLoc, and DL conflicts with DataLayout
Ah, okay. Indeed. I'd forgotten about that.


https://reviews.llvm.org/D40912