[PATCH] D40912: TLI: Expose all MMO flags in getTgtMemIntrinsic

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 11:26:02 PST 2017


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

Minor comment below, but otherwise LGTM.



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:5779
 SDValue SelectionDAG::getMemIntrinsicNode(
-    unsigned Opcode, const SDLoc &dl, SDVTList VTList, ArrayRef<SDValue> Ops,
-    EVT MemVT, MachinePointerInfo PtrInfo, unsigned Align, bool Vol,
-    bool ReadMem, bool WriteMem, unsigned Size) {
+    unsigned Opcode, const SDLoc &SL, SDVTList VTList, ArrayRef<SDValue> Ops,
+    EVT MemVT, MachinePointerInfo PtrInfo, unsigned Align,
----------------
Please don't change dl to SL here. dl is our standard names for these things (because they're essentially debug locations and everyone knows that dl/DL means).


https://reviews.llvm.org/D40912





More information about the llvm-commits mailing list