[PATCH] D41222: Handle previously ASAN-instrumented IR gracefully when ASAN re-invoked

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 10:53:18 PST 2017


vitalybuka added inline comments.


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:2422
+  // Skip modules which already have ASan instrumentation.
+  if (isAlreadyAsanInstrumented(*F.getParent()))
+    return false;
----------------
Simple if statements here and below. However it looks like that existing ifs do not follow LLVM style. So please keep the patch as is.


https://reviews.llvm.org/D41222





More information about the llvm-commits mailing list