[PATCH] D40967: [LLD][ELF] Remove Duplicate .ARM.exidx sections

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 08:47:44 PST 2017


peter.smith updated this revision to Diff 126974.
peter.smith added a comment.

Thanks very much for the comments, I've applied the suggested changes.

>> +// RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
>>  +// RUN: ld.lld %t --no-merge-exidx-entries -o %t2 2>&1
> 
> Why the 2>&1 ?

No good reason, I've taken them out.

>> +// CHECK-NEXT:  100f4 300f0000 01000000
> 
> Is it easy to check that this is the end of the section?

I've added a CHECK-NEXT for the line afterwords (.ARM.extab section name).

> Cheers,
> Rafael


https://reviews.llvm.org/D40967

Files:
  ELF/Config.h
  ELF/Driver.cpp
  ELF/Options.td
  ELF/Writer.cpp
  test/ELF/arm-exidx-dedup.s
  test/ELF/arm-exidx-gc.s
  test/ELF/arm-exidx-order.s
  test/ELF/arm-exidx-sentinel-orphan.s
  test/ELF/arm-static-defines.s
  test/ELF/linkerscript/arm-exidx-sentinel-and-assignment.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40967.126974.patch
Type: text/x-patch
Size: 13113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171214/40abef48/attachment.bin>


More information about the llvm-commits mailing list