wrong attribution [Re: r320686 - Remove redundant includes from lib/Target/AArch64]

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 07:48:57 PST 2017


There was some problem in `git-svn` that caused the whole tree to be
wiped out and replaced by lib/Target yesterday (in llvm-mirror and
llvm-project).
Anton has the details.

On Thu, Dec 14, 2017 at 3:02 AM, Fedor Sergeev via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Arrr... could somebody, please, help me to understand me how *this* change
> happened to be attributed to me?
>
> Most definitely I did not do this change myself, I just committed the
> rL320687 through the normal
> git-svn routine as described in getting-started docs (git svn rebase -l; git
> svn dcommit).
>
> When I look through the git ref-log I see this:
> ] git log -2 arcpatch-D41203@{2} --format=short
> commit e53071167ddc94b72b5ec232ec022af34c36c966
> Author: Fedor Sergeev <fedor.sergeev at azul.com>
>     [PM][InstCombine] fixing omission of AliasAnalysis in new-pass-manager's
> version of InstCombine
>
> commit faa3321d279d6b17606d693d47d8d8dccb6c8339
> Author: Michael Zolotukhin <mzolotukhin at apple.com>
>     Remove redundant includes from lib/Target/AArch64.
> ]
>
> And suddenly it becomes attributed to myself, most likely by git svn
> dcommit.
> Its not my first commit through this machinery, and I'm kinda lost on what
> went wrong.
>
> regards,
>   Fedor.
>
> On 12/14/2017 01:36 PM, Fedor Sergeev via llvm-commits wrote:
>>
>> Author: fedor.sergeev
>> Date: Thu Dec 14 02:36:20 2017
>> New Revision: 320686
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=320686&view=rev
>> Log:
>> Remove redundant includes from lib/Target/AArch64.
>>
>> Modified:
>>      llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp
>>
>> Modified: llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp?rev=320686&r1=320685&r2=320686&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp (original)
>> +++ llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp Thu Dec 14
>> 02:36:20 2017
>> @@ -12,7 +12,6 @@
>>   //
>>
>> //===----------------------------------------------------------------------===//
>>   -#include "AArch64MacroFusion.h"
>>   #include "AArch64Subtarget.h"
>>   #include "llvm/CodeGen/MacroFusion.h"
>>   #include "llvm/CodeGen/TargetInstrInfo.h"
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list