[PATCH] D41190: [tsan] Separate the constants in libignore and bump the maximum for instrumented libraries

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 23:54:06 PST 2017


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/sanitizer_common/sanitizer_libignore.cc:83
             atomic_load(&ignored_ranges_count_, memory_order_relaxed);
-        CHECK_LT(idx, kMaxLibs);
+        CHECK_LT(idx, kMaxIgnoredRanges);
         ignored_code_ranges_[idx].begin = range.beg;
----------------
Probably better to switch to ARRAY_SIZE(ignored_code_ranges_) at this point.



================
Comment at: lib/sanitizer_common/sanitizer_libignore.cc:112
             atomic_load(&instrumented_ranges_count_, memory_order_relaxed);
-        CHECK_LT(idx, kMaxLibs);
+        CHECK_LT(idx, kMaxInstrumentedRanges);
         instrumented_code_ranges_[idx].begin = range.beg;
----------------
Ditto.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41190





More information about the llvm-commits mailing list