[PATCH] D41105: [ELF] Fix placement of a sentinel entry in the .ARM.exidx section.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 16:59:46 PST 2017


Igor Kudrin <ikudrin at accesssoftek.com> writes:

> Maybe I can't fully understand? your idea, but to put the relocation we still need to find the reference section, so I can't see why this approach is simpler than the current code. And we still have to write EXIDX_CANTUNWIND?, so we can't get rid of  'ARMExidxSentinelSection::writeTo()' altogether. Am I right?

Yes. I guess the real difference would be to create the sentinel later
and give it a pointer to the last non sentinel section. Changing it to
use a relocation is probably not worth it.

Cheers,
Rafael


More information about the llvm-commits mailing list