[PATCH] D41113: [LLVMgold] Don't set resolutions for undefined symbols to 'Prevailing'

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

>   I meant that the asm_undefined2.ll test should cause this assert without the fix in this patch 

Without modification to gold-plugin.cpp assertion fires. I've added these lines of code:

  if (Res.Prevailing) {
    assert(GlobalRes.IRName.empty() || !Sym.getIRName().empty());
    GlobalRes.IRName = Sym.getIRName();
  }

> Not sure what you mean about marking via llvm-lto2

I meant that this assertion may also fire (and actually does) when you set symbol resolutions manually, which is possible to do using llvm-lto and llvm-lto2.
This is the reason why it breaks one of llvm-lto test cases.


https://reviews.llvm.org/D41113