[PATCH] D38566: [SimplifyCFG] don't sink common insts too soon (PR34603)

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 126770.
spatel added a comment.
Herald added a subscriber: eraman.

Patch updated:

1. Removed the sinking option from the SimplifyCFG invocations that are part of the canonicalization phase.
2. Speculatively implemented what I suggested in the last comment - added a SimplifyCFG pass ahead of vectorization to allow the sinking transform (help the vectorizers by creating larger blocks with selects).


https://reviews.llvm.org/D38566

Files:
  include/llvm/Transforms/Scalar.h
  include/llvm/Transforms/Scalar/SimplifyCFG.h
  include/llvm/Transforms/Utils/Local.h
  lib/Passes/PassBuilder.cpp
  lib/Target/AArch64/AArch64TargetMachine.cpp
  lib/Target/ARM/ARMTargetMachine.cpp
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Scalar/SimplifyCFGPass.cpp
  lib/Transforms/Utils/SimplifyCFG.cpp
  test/DebugInfo/Generic/simplifycfg_sink_last_inst.ll
  test/Other/new-pm-defaults.ll
  test/Other/new-pm-thinlto-defaults.ll
  test/Transforms/PhaseOrdering/simplifycfg-options.ll
  test/Transforms/SimplifyCFG/no-md-sink.ll
  test/Transforms/SimplifyCFG/sink-common-code.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38566.126770.patch
Type: text/x-patch
Size: 12795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171213/e5d16992/attachment-0001.bin>