[PATCH] D41113: [LLVMgold] Don't set resolutions for undefined symbols to 'Prevailing'

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 added a comment.

> Can you add an assert for this

`check-all` passes with this, but we can explicitly mark asm undefined symbol as prevailing using llvm-lto(2) and trigger this assert. Is this OK?

> What happens if the asm does have the prevailing def? Isn't that possible? In that case the IRName will never be set.

When you have asm def as prevailing (gold plugin) we mark `foo` as dead in **ModuleSummaryIndex**. It's only check for

  if (AsmUndefinedRefs.count(GV.getName()))
    return true;

in thinLTOInternalizeModule which prevents DCE.


https://reviews.llvm.org/D41113