[PATCH] D41112: [FuzzMutate] Correctly split landingpad blocks

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL320571: [FuzzMutate] Correctly split landingpad blocks (authored by igor.laevsky, committed by ).

Repository:
  rL LLVM

https://reviews.llvm.org/D41112

Files:
  llvm/trunk/lib/FuzzMutate/Operations.cpp
  llvm/trunk/unittests/FuzzMutate/OperationsTest.cpp


Index: llvm/trunk/lib/FuzzMutate/Operations.cpp
===================================================================
--- llvm/trunk/lib/FuzzMutate/Operations.cpp
+++ llvm/trunk/lib/FuzzMutate/Operations.cpp
@@ -142,9 +142,14 @@
   auto buildSplitBlock = [](ArrayRef<Value *> Srcs, Instruction *Inst) {
     BasicBlock *Block = Inst->getParent();
     BasicBlock *Next = Block->splitBasicBlock(Inst, "BB");
+
+    // If it was an exception handling block, we are done.
+    if (Block->isEHPad())
+      return nullptr;
+
+    // Loop back on this block by replacing the unconditional forward branch
+    // with a conditional with a backedge.
     if (Block != &Block->getParent()->getEntryBlock()) {
-      // Loop back on this block by replacing the unconditional forward branch
-      // with a conditional with a backedge.
       BranchInst::Create(Block, Next, Srcs[0], Block->getTerminator());
       Block->getTerminator()->eraseFromParent();
 
Index: llvm/trunk/unittests/FuzzMutate/OperationsTest.cpp
===================================================================
--- llvm/trunk/unittests/FuzzMutate/OperationsTest.cpp
+++ llvm/trunk/unittests/FuzzMutate/OperationsTest.cpp
@@ -211,6 +211,35 @@
   EXPECT_FALSE(verifyModule(M, &errs()));
 }
 
+TEST(OperationsTest, SplitEHBlock) {
+  // Check that we will not try to branch back to the landingpad block using
+  // regular branch instruction
+
+  LLVMContext Ctx;
+  const char *SourceCode =
+      "declare i32* @f()"
+      "declare i32 @personality_function()"
+      "define i32* @test() personality i32 ()* @personality_function {\n"
+      "entry:\n"
+      "  %val = invoke i32* @f()\n"
+      "          to label %normal unwind label %exceptional\n"
+      "normal:\n"
+      "  ret i32* %val\n"
+      "exceptional:\n"
+      "  %landing_pad4 = landingpad token cleanup\n"
+      "  ret i32* undef\n"
+      "}";
+  auto M = parseAssembly(SourceCode, Ctx);
+
+  // Get the landingpad block
+  BasicBlock &BB = *std::next(M->getFunction("test")->begin(), 2);
+
+  fuzzerop::OpDescriptor Descr = fuzzerop::splitBlockDescriptor(1);
+
+  Descr.BuilderFunc({ConstantInt::getTrue(Ctx)},&*BB.getFirstInsertionPt());
+  ASSERT_TRUE(!verifyModule(*M, &errs()));
+}
+
 TEST(OperationsTest, SplitBlockWithPhis) {
   LLVMContext Ctx;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41112.126718.patch
Type: text/x-patch
Size: 2295 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171213/58c0260b/attachment.bin>