[PATCH] D41125: [llvm-objcopy] Add -o option to llvm-objcopy

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

There's an issue here, based on my reading of the man page for strip. Strip takes a list of objects that are to be stripped, and modifies them in place. As things stand, this patch will mean llvm-strip a.o b.o will strip a.o and emit it as b.o, which is a potentially very confusing issue if trying to use it as a drop-in replacement. I don't mind if you don't at this point support multiple inputs, but I think that the implicit output needs to be illegal for llvm-strip.

Aside from that, this change looks fine to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D41125