[PATCH] D40898: [Sanitizers] Basic sanitizer Solaris support (PR 33274)

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 10:45:04 PST 2017


krytarowski added a comment.

I propose to rebase it to HEAD as this patch might not apply cleanly.



================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:144
 #endif
+#if SANITIZER_SOLARIS && !defined(_LP64)
+typedef long pid_t;
----------------
Are there still !LP64 Solaris systems?


================
Comment at: lib/sanitizer_common/sanitizer_mutex.h:99
+  // Solaris mutex_t has a member that requires 64-bit alignment.
+  ALIGNED(8)
+#endif
----------------
I would remove ifdef here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40898





More information about the llvm-commits mailing list