[PATCH] D40944: [profile] Enable on Solaris

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with a nit -- please add the comment we discussed in InstrProfilingPort.h.



================
Comment at: lib/profile/InstrProfilingPort.h:9
 \*===----------------------------------------------------------------------===*/
 
 #ifndef PROFILE_INSTRPROFILING_PORT_H_
----------------
This is a good place to add a comment stating that this header must be textually #included before all others.


================
Comment at: lib/profile/InstrProfilingUtil.c:90
+  int R = uname(&N);
+  if (R >= 0) {
     strncpy(Name, N.nodename, Len);
----------------
Nice catch.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40944