[PATCH] D35561: [mips] Insert a COPY node for SW16_MM

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 06:51:26 PST 2017


sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.

I believe the entire hunk for handling RegisterSDNodes should be sunk into AddRegisterOperand as your change mimics portions of the logic there.



================
Comment at: lib/CodeGen/SelectionDAG/InstrEmitter.cpp:408
+
+    if(OpRC && IIRC && OpRC != IIRC && TargetRegisterInfo::isVirtualRegister(VReg)) {
+      unsigned NewVReg = MRI->createVirtualRegister(IIRC);
----------------
Space after the if, and the line is overly long.


https://reviews.llvm.org/D35561





More information about the llvm-commits mailing list