[lld] r320286 - PPC32: Support R_PPC_PLTREL32 in static mode.

vit9696 via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 01:29:58 PST 2017


Perfect, thank you.

> 12 дек. 2017 г., в 1:43, Rafael Avila de Espindola <rafael.espindola at gmail.com> написал(а):
> 
> vit9696 <vit9696 at avp.su> writes:
> 
>> Hello,
>> 
>> Thanks for pointing out an interesting specialty regarding lld optimisations. I indeed was unaware of fromPlt, since I only looked into PPC-specific code. I have just checked and can confirm that R_PLT_PC also works fine thanks to that feature.
>> 
>> In this case the code could be even cleaner, and one should be safe to replace R_PC by R_PLT_PC. I do not mind submitting a patch for a review that will replace one thing by the other, but since it is an obvious one-line change (which will somebody have to commit it for me anyway), could you please apply the change right away? I attached the diff to the message.
> 
> Oops. I missed the attachment somehow.
> 
> In any case, I don't think we need a special comment for returning
> R_PLT_PC since that is the correct value.
> 
> I changed it in r320430.
> 
> Thanks,
> Rafael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171212/853e0d05/attachment.sig>


More information about the llvm-commits mailing list