[PATCH] D41097: [ELF] Use shell to check the file permissions

[Petr Hosek via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL320442: [ELF] Use shell to check the file permissions (authored by phosek).

Changed prior to commit:
  https://reviews.llvm.org/D41097?vs=126473&id=126474#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D41097

Files:
  lld/trunk/test/ELF/file-access.s
  lld/trunk/test/lit.cfg.py


Index: lld/trunk/test/lit.cfg.py
===================================================================
--- lld/trunk/test/lit.cfg.py
+++ lld/trunk/test/lit.cfg.py
@@ -91,11 +91,3 @@
     if 'GNU tar' in tar_version.stdout.read().decode():
         config.available_features.add('gnutar')
     tar_version.wait()
-
-stat_executable = lit.util.which('stat', config.environment['PATH'])
-if stat_executable:
-    stat_version = subprocess.Popen(
-        [stat_executable, '--version'], stdout=subprocess.PIPE, env={'LANG': 'C'})
-    if 'GNU coreutils' in stat_version.stdout.read().decode():
-        config.available_features.add('gnustat')
-    stat_version.wait()
Index: lld/trunk/test/ELF/file-access.s
===================================================================
--- lld/trunk/test/ELF/file-access.s
+++ lld/trunk/test/ELF/file-access.s
@@ -1,15 +1,12 @@
-# REQUIRES: x86, gnustat
+# REQUIRES: x86, shell
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 # RUN: ld.lld -r %t.o -o %t1.o
-# RUN: stat -c %%A %t1.o | FileCheck --check-prefix=CHECK-RELOC %s
-# CHECK-RELOC: -rw-r--r--
+# RUN: [ ! -x %t1.o ]
 # RUN: ld.lld -shared %t.o -o %t2.so
-# RUN: stat -c %%A %t2.so | FileCheck --check-prefix=CHECK-SHARED %s
-# CHECK-SHARED: -rwxr-xr-x
+# RUN: [ -x %t2.so ]
 # RUN: ld.lld %t.o -o %t3
-# RUN: stat -c %%A %t3 | FileCheck --check-prefix=CHECK-EXEC %s
-# CHECK-EXEC: -rwxr-xr-x
+# RUN: [ -x %t3 ]
 
 .global _start
 _start:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41097.126474.patch
Type: text/x-patch
Size: 1458 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171212/e8c58791/attachment-0001.bin>