[lld] r320442 - [ELF] Use shell to check the file permissions

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 16:31:46 PST 2017


Author: phosek
Date: Mon Dec 11 16:31:46 2017
New Revision: 320442

URL: http://llvm.org/viewvc/llvm-project?rev=320442&view=rev
Log:
[ELF] Use shell to check the file permissions

This is less error-prone to mask settings than stat.

Differential Revision: https://reviews.llvm.org/D41097

Modified:
    lld/trunk/test/ELF/file-access.s
    lld/trunk/test/lit.cfg.py

Modified: lld/trunk/test/ELF/file-access.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/file-access.s?rev=320442&r1=320441&r2=320442&view=diff
==============================================================================
--- lld/trunk/test/ELF/file-access.s (original)
+++ lld/trunk/test/ELF/file-access.s Mon Dec 11 16:31:46 2017
@@ -1,15 +1,12 @@
-# REQUIRES: x86, gnustat
+# REQUIRES: x86, shell
 
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 # RUN: ld.lld -r %t.o -o %t1.o
-# RUN: stat -c %%A %t1.o | FileCheck --check-prefix=CHECK-RELOC %s
-# CHECK-RELOC: -rw-r--r--
+# RUN: [ ! -x %t1.o ]
 # RUN: ld.lld -shared %t.o -o %t2.so
-# RUN: stat -c %%A %t2.so | FileCheck --check-prefix=CHECK-SHARED %s
-# CHECK-SHARED: -rwxr-xr-x
+# RUN: [ -x %t2.so ]
 # RUN: ld.lld %t.o -o %t3
-# RUN: stat -c %%A %t3 | FileCheck --check-prefix=CHECK-EXEC %s
-# CHECK-EXEC: -rwxr-xr-x
+# RUN: [ -x %t3 ]
 
 .global _start
 _start:

Modified: lld/trunk/test/lit.cfg.py
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/lit.cfg.py?rev=320442&r1=320441&r2=320442&view=diff
==============================================================================
--- lld/trunk/test/lit.cfg.py (original)
+++ lld/trunk/test/lit.cfg.py Mon Dec 11 16:31:46 2017
@@ -91,11 +91,3 @@ if tar_executable:
     if 'GNU tar' in tar_version.stdout.read().decode():
         config.available_features.add('gnutar')
     tar_version.wait()
-
-stat_executable = lit.util.which('stat', config.environment['PATH'])
-if stat_executable:
-    stat_version = subprocess.Popen(
-        [stat_executable, '--version'], stdout=subprocess.PIPE, env={'LANG': 'C'})
-    if 'GNU coreutils' in stat_version.stdout.read().decode():
-        config.available_features.add('gnustat')
-    stat_version.wait()




More information about the llvm-commits mailing list