[PATCH] D39034: [WIP][GlobalISel][TableGen] Optimize MatchTable for faster instruction selection

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:811
 
-    for (const auto &Predicate : predicates())
+    unsigned OpIdx = (*predicates_begin())->getOpIdx();
+    (void)OpIdx;
----------------
qcolombet wrote:
> dsanders wrote:
> > This will crash if predicates_begin() == predicates_end()
> We check this case in the previous statement, right?
Scratch this one. We check it a little earlier, I just didn’t notice because it was off screen


Repository:
  rL LLVM

https://reviews.llvm.org/D39034