[PATCH] D41029: [JumpTables][PowerPC] Let targets decide which switch instructions are suitable for jump tables

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 14:08:15 PST 2017


hans added a comment.

Sorry for being slow to respond.

I can't comment on the PPC specifics, but I support allowing the target to decide whether to emit a jump table in this way.



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1141
+/// The \p SI parameter is used to avoid reporting that a block that contains
+/// the SwitchInst we're inspecting uses the CTR.
+bool PPCTargetLowering::mightUseCTR(const BasicBlock *BB,
----------------
Should the comment be with the declaration in the .h file instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D41029





More information about the llvm-commits mailing list