[PATCH] D41084: [dsymutil] Accept DWARF4 line tables.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 12:55:13 PST 2017


JDevlieghere added inline comments.


================
Comment at: tools/dsymutil/DwarfLinker.cpp:3235
   // Finished extracting, now emit the line tables.
   uint32_t PrologueEnd = *StmtList + 10 + LineTable.Prologue.PrologueLength;
   // FIXME: LLVM hardcodes it's prologue values. We just copy the
----------------
probinson wrote:
> This calculation is incorrect for v5, which has an extra 2 bytes of information before the header_length field.  Your choice whether to fix the calculation or restrict dsymutil to no higher than v4.
Thanks Paul! I will update the calculation. 


Repository:
  rL LLVM

https://reviews.llvm.org/D41084





More information about the llvm-commits mailing list